This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: dialog name incorrect when creating new dialog in form editor#1605
Merged
a-b-r-o-w-n merged 10 commits intomasterfrom Nov 25, 2019
Merged
fix: dialog name incorrect when creating new dialog in form editor#1605a-b-r-o-w-n merged 10 commits intomasterfrom
a-b-r-o-w-n merged 10 commits intomasterfrom
Conversation
0a16603 to
010afb9
Compare
a-b-r-o-w-n
suggested changes
Nov 22, 2019
Contributor
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
I still see a flicker when creating a dialog from the form.
a-b-r-o-w-n
approved these changes
Nov 25, 2019
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrong behavior
the

BeginDialogaction can not get the dialog name after the user create a new one from the form. But there is a newbeginDialogaction with the dialog name in the new dialog trigger steps.root cause
in
createDialogBasefunction, it jumps to new dialog after creating the dialog, but the operation that setting the dialog name to the oldbeginDialogaction is in thecreateDialogpromisethenfunction. So the operation in formEditor takes place in the new dialog page.Solution
Move
navTofunction fromcreateDialogBasetoformEditorfunction.createDialogBasejust deals with the data logic.Task Item
closes #1144
Type of change
Please delete options that are not relevant.
Checklist
Screenshots